Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4111

The environment_scenario-* acceptance tests aren't asserting their success/failure and are therefore always 'passing'

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: PUP 4.1.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Language 2015-04-15, Language 2015-04-29

      Description

      These tests were written to collect results rather than failing early, so that they could be reviewed at once.

      When we broke up the stable:acceptance/tests/environment/directory.rb into master:acceptance/tests/environment/environment_scenario-*.rb subtests, we forgot to ensure that the tests make a final assertion that the results are either all passing or all failing.

      The final assertion call that is missing is an:

      assert_review(results) call at the end of the test (using the lib/puppet/acceptance/environment_utils.rb helper)

      They are currently failures in these tests that are being masked by this.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  joshua.partlow Joshua Partlow
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support