Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-2630 Server-set global variables like $::environment get overwritten by client facts
  3. PUP-4419

create acceptance to ensure client does not overwrite server-set variables

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: PUP 4.1.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Language 2015-04-29, Language 2015-05-13, Language 2015-05-27

      Description

      from the parent (quoting Henrik Lindberg):

      After discussion with Eric Soerenson, we decided that it was best to make this an opt-in and that we are not adding a function - this for the sake of consistency between $facts, $trusted_facts, and $server_facts. This means:

      • At the same place where we currently set $trusted_facts we should also set $server_facts if users have opted in
      • The values set in $server_facts are the @server_facts set in the node by the compiler indirection + the current environment name
      • The user opts in by using the setting :trusted_server_facts
      • The setting is false by default
      • We issue a warning if any node parameter is overwritten

      QA Risk Analysis


      N/A for testing tickets

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              erict Eric Thompson
              QA Contact:
              Eric Thompson Eric Thompson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support