Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4458

Refactor validation of 4.x parameter signatures

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 4.3.0
    • None
    • None
    • 3
    • Language 2015-04-29, Language 2015-05-13, Language 2015-05-27, Language 2015-07-08, Language 2015-09-30, Language 2015-10-14
    • Bug Fix
    • This makes the typechecking and reporting of parameter types consistent. Earlier there were several different implementatations and they differed in how they checked and reported type mismatches.

    Description

      The code that performs validation of parameters when calling functions, lambdas, or instantiating resource or class definitions resides in different places today and produces different error messages. This code should be refactored so that it handles all types of parameter validation.

      The code must be able to handle both pure indexed based parameter passing (functions and lambdas) and parameters passed by name (resource and class instantiations).

      QA

      risk: low (refactor)
      probability: medium
      severity: low
      testing layer: unit/acceptance (as-is)

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. PUP-1985 Allow function & class & define parameters to reference earlier parameters

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PUP-2315 function call error message about mis-matched arguments is hard to understand

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          is blocked by

          Improvement - An improvement or enhancement to an existing feature or task. PUP-4702 Replace rgen model for the Puppet Type system with immutable classes

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PUP-5603 Unset metaparameters throw strict_variables errors

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PUP-5207 spacing around commas incorrect when complaining about missing EPP values

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          links to

          Web Link PR-4036

          Activity

            People

              qa qa
              thomas.hallgren Thomas Hallgren
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support