Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4538

plugin face application does not use source permissions during fact sync

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.2.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Client 2015-06-10
    • Release Notes:
      Bug Fix

      Description

      If you use the plugin face application to download plugins, then any executable external facts will not be executable and will run into the same problem described in PUP-4420.

      $ bundle exec puppet plugin download --server ql1prr50yqgx40d.delivery.puppetlabs.net --http_debug
      ...
      <- "GET /puppet/v3/file_metadatas/pluginfacts?environment=production&links=follow&recurse=true&ignore=.svn&ignore=CVS&ignore=.git&checksum_type=md5 HTTP/1.1\r\nAccept: pson, yaml, binary\r\nX-Puppet-Version: 4.0.0\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nUser-Agent: Ruby\r\nConnection: close\r\nHost: ql1prr50yqgx40d.delivery.puppetlabs.net:8140\r\n\r\n"
      -> "HTTP/1.1 200 OK\r\n"
      -> "Date: Thu, 07 May 2015 17:18:56 GMT\r\n"
      -> "Content-Type: text/pson;charset=ISO-8859-1\r\n"
      -> "X-Puppet-Version: 4.0.0\r\n"
      -> "Connection: close\r\n"
      -> "Server: Jetty(9.1.z-SNAPSHOT)\r\n"
      -> "\r\n"
      reading all...
      -> "[{\"path\":\"/etc/puppetlabs/code/environments/production/modules/foo/facts.d\",\"relative_path\":\".\",\"links\":\"follow\",\"owner\":998,\"group\":997,\"mode\":420,\"checksum\":{\"type\":\"ctime\",\"value\":\"{ctime}2015-05-07 10:13:17 -0700\"},\"type\":\"directory\",\"destination\":null},{\"path\":\"/etc/puppetlabs/code/environments/production/modules/foo/facts.d\",\"relative_path\":\"foo.sh\",\"links\":\"follow\",\"owner\":998,\"group\":997,\"mode\":420,\"checksum\":{\"type\":\"md5\",\"value\":\"{md5}940339479f148a731c7b820dfba2223d\"},\"type\":\"file\",\"destination\":null}]"
      

      The plugin face application should use /lib/puppet/configurer/downloader_factory.rb to create the downloader objects so that we have consistent behavior when using puppet agent and puppet plugin

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  josh Josh Cooper
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: