Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4670

puppet parser validate gives a warning when exported resources are present

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Cannot Reproduce
    • Affects Version/s: PUP 3.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
    • Template:

      Description

      Overview

      If exported resources are present, puppet parser validate will print a warning message (in red).

      Expected result

      Validation should only check the syntax of the file and therefore should return no warning messages of this nature.

      Actual result

      Users receive a warning message:

      Warning: You cannot collect without storeconfigs being set 
      

      Problems this causes

      Unnecessarily confuses and distresses users (puppet parser validate) is typically used in pre-commit git hooks so this is something users could encounter frequently and when dealing with code that they have not personally authored.

      Testcase

      echo '@@notify{ "ssh": }' | puppet parser validate
      

      Suggested fix

      Validate syntax only and do not print a warning message

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                eric.sorenson Eric Sorenson
                Reporter:
                geoff.williams Geoff Williams
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support