Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4713

Race condition in node/environment.rb's modules_by_path

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Template:
    • Epic Link:

      Description

      Reviewing pup-3710, we opted to backport one change (see https://github.com/puppetlabs/puppet/pull/4015), but Branan Riley noted that there is a race condition in the original pe-puppet logic. Rather than check for the path existing and then chdir'ing to it, it should chdir and catch the exception.

      Even better, it shouldn't chdir all over the place.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              kylo Kylo Ginsberg
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support