[PUP-4737] Group resource should use autorequire for members and other user specific fields - Puppet Tickets

Details

Type: Improvement
Status: Accepted
Priority: Minor
Resolution: Unresolved
Affects Version/s: PUP 4.1.0
Fix Version/s: None
Component/s: Types and Providers, Windows
Labels:
- autorequire
- group
- help_wanted
- type_and_provider
- user
- windows

With a puppet manifest similar to the following:

group { 'TestUsers':

  ensure  => 'present',

  members => ['Administrators','tim'],

user { 'tim':

  ensure => present,

  password => '123Adc!dd',

  groups => ['Administrators','Users'],

The message against 4.1.0 and below will look like the following:

Error: Could not resolve name: tim

Error: /Stage[main]/Main/Group[TestUsers]: Could not evaluate: Puppet::Util::Log requires a message

Notice: /Stage[main]/Main/User[tim]/ensure: created

In Puppet 4.2.x and above (the message will look like the following - based on ~~PUP-4386~~ fixing the messaging):

Notice: Compiled catalog for windows.vm in environment production in 3.40 seconds

Error: Could not resolve name: tim

Error: /Stage[main]/Main/Group[TestUsers]/members: change from  to BUILTIN\Administrators,tim failed: Could not resolve name: tim

Notice: /Stage[main]/Main/User[tim]/ensure: created

This is easily resolved by ensuring that all users are ensured prior to ensuring the group, but it would be nice to autorequire on such a setting.

relates to

PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member