Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4776

`puppet agent arg` silently eats arguments and runs the agent

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 3.7.4, PUP 3.8.1, PUP 4.1.0
    • Fix Version/s: PUP 4.3.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Client 2015-07-22
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Previously, puppet agent would allow arguments to be passed to it that it didn't understand, and would ignore them. For example, {{puppet agent disable}}, and because puppet agent deamonizes by default, this would actually start the agent running in the background instead of disabling it. Now puppet agent will reject options it doesn't understand.
      Show
      Previously, puppet agent would allow arguments to be passed to it that it didn't understand, and would ignore them. For example, {{puppet agent disable}}, and because puppet agent deamonizes by default, this would actually start the agent running in the background instead of disabling it. Now puppet agent will reject options it doesn't understand.

      Description

      In general, `puppet <thing> help` tends to provide help text. This seems to be entirely accidental, because `puppet <thing> help` calls `puppet thing` with the argument `help`, which is invalid in many cases.

      `puppet agent help` silently launches the agent in the background and provides no help text. If one accidentally types `puppet agent disable` instead of `puppet agent --disable`, the changes one wanted to avoid applying are instead immediately applied.

      It would be awesome if `puppet agent` died, preferably loudly, if called with extra arguments.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peter.huene Peter Huene
              Reporter:
              mdonahue Mason Donahue
              QA Contact:
              Eric Thompson
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support