Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4951

"puppet module build" too picky about SemVer

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Duplicate
    • None
    • None
    • None
    • None

    Description

      Parsing the metadata.json uses SemVer from lib/semver.rb (why not use Semantic everywhere?) which is unaccepting of SemVer 2.0:

      "A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version."

      "Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version."

      .. while the RegEx used is /^v?(\d+)\.(\d+)\.(\d+)(-[0-9A-Za-z-]*|)$/ ..

      Version "v2.5-foobar" is also invalid, while "v2.5.0-foobar" is fine.

      Semantic 1.4.1 fares somewhat better.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              count Andreas Kotes
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support