Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5032

Update node terminus configured_environment to mirror agent_specified_environment

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 4.2.0
    • Fix Version/s: PUP 4.3.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Client 2015-09-16, Client 2015-09-30, Client 2015-10-14
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      When the configured_environment property was added to node and catalog communication, it was always set even when accepting the default. This was less useful than intended, as a node classifier may expect to know whether the agent explicitly requested that environment or is using the default. Change to only set the configured_environment property if an environment was explicitly requested on the agent, i.e. via puppet.conf or the command-line.
      Show
      When the configured_environment property was added to node and catalog communication, it was always set even when accepting the default. This was less useful than intended, as a node classifier may expect to know whether the agent explicitly requested that environment or is using the default. Change to only set the configured_environment property if an environment was explicitly requested on the agent, i.e. via puppet.conf or the command-line.

      Description

      Puppet's communication with the node and catalog terminus included a configured_environment option in the last release. That option sometimes includes redundant or irrelevant information when Puppet[:environment] has the default setting. That redundant information precludes it from being used to identify when an agent has explicitly requested a particular environment.

      Change the behavior of configured_environment to only be set when the environment setting is explicitly set.

      This would technically be a breaking change in Puppet's node and catalog terminus behavior, but seeing as we have yet to document it I think it's a reasonable break.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                michael.smith Michael Smith
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support