Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5120

Send checksum_type and static_catalog query params in catalog request

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.4.0
    • Component/s: None
    • Labels:
      None
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      The agent will send two additional query parameters when making a catalog request, enabling the puppet server to generate a static catalog.

      Description

      Currently, when the agent applies a catalog, it sends a file_metadata request for each file resource along with the checksum_type that the master should use to compute the checksum. The checksum_type originates in either the manifest (and preserved in the catalog), or if none was specified, the agent's default Puppet[:digest_algorithm].

      When static catalogs are enabled, the file metadata inlining process will need to choose a digest algorithm if none is specified in the manifest. To ensure the master chooses a checksum suitable for the agent, the agent needs to send its desired checksum in the catalog request as a request parameter. The value should either be the value of Puppet[:digest_algorithm] or it should be an ordered list of algorithms the agent supports. The only reason for choosing the latter is for future proofing, and in the case where the agent's default is not supported by the master, which seems highly unlikely.

      See PUP-1840 for background.

      Also, 4.4 client should always request a static catalog by sending static_catalog=true query parameter. The server will decide (based on PUP-5694) whether to build a static catalog.

      As part of this ticket, update the catalog API docs.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                josh Josh Cooper
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support