Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5398

Fix regression that reintroduced file watching for directory environments

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 3.8.4
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Language 2015-10-28
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      A regression introduced in 3.7.5 would cause a directory based environment to reload if a file was changed, or cause a premature cache timeout if the filetimeout setting had a shorter time than the environment cache.
      The regression could also cause performance degradation in general due to many calls to get status of files.
      Show
      A regression introduced in 3.7.5 would cause a directory based environment to reload if a file was changed, or cause a premature cache timeout if the filetimeout setting had a shorter time than the environment cache. The regression could also cause performance degradation in general due to many calls to get status of files.

      Description

      The fix for PUP-3389 introduced a regression that resulted in all manifests being watched for directory environments. This has the effect that directory environments will be evicted when the filetimeout triggers (default 15s). The settings "infinite" therefore does not have the intended effect.

      This also causes performance issues since it means using very inefficient file watching that results in potentially millions of kernel calls to stat files.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  henrik.lindberg Henrik Lindberg
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support