Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5538

Puppet fails to convert Windows Unicode group or user names to sids

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • PUP 3.8.4, PUP 4.3.0
    • PUP 4.3.2
    • Windows
    • Bug Fix
    • Hide
      The handling of Unicode user and group names in Windows was previously deficient, and could present a number of errors when used in manifests, depending on the characters used in the name and the current local codepage. The user/group might fail to be created, might be created with the wrong characters, or might present failures on subsequent runs after initial creation. Using the SID of the user/group as a workaround could also fail. These issues have been corrected.
      Show
      The handling of Unicode user and group names in Windows was previously deficient, and could present a number of errors when used in manifests, depending on the characters used in the name and the current local codepage. The user/group might fail to be created, might be created with the wrong characters, or might present failures on subsequent runs after initial creation. Using the SID of the user/group as a workaround could also fail. These issues have been corrected.

    Description

      The win32-security gem that Puppet uses for SID conversion uses ANSI versions of APIs that can make it fail to convert Unicode group / user names to SIDs properly.

      https://github.com/puppetlabs/puppet-win32-ruby/blob/2.1.x-x64/ruby/lib/ruby/gems/2.1.0/gems/win32-security-0.2.5/lib/win32/security/windows/functions.rb#L79-L80

      Attachments

        1. umlat-ss1.PNG
          umlat-ss1.PNG
          12 kB
        2. umlat-ss2.PNG
          umlat-ss2.PNG
          11 kB
        3. umlat-ss3.PNG
          umlat-ss3.PNG
          12 kB
        4. umlat-ss4.PNG
          umlat-ss4.PNG
          10 kB
        5. umlat-ss5.PNG
          umlat-ss5.PNG
          10 kB

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. PUP-5684 Windows ADSI User and Group exists? checks are invalid

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MODULES-9215 ACL: Cannot update ACL if there is an existing unmanaged ACE for ALL RESTRICTED APPLICATION PACKAGES

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. PUP-5728 Change default parsing of manifest files to UTF-8

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. PUP-5709 Search for use of the Puppet Utils SID api within the forge

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. PUP-5717 Ruby crash when using Unicode codepage on windows when writing to STDOUT on a console

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Task - A task that needs to be done. PUP-5560 Look at Improving Unicode for all Windows gems

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Task - A task that needs to be done. PUP-5735 Remove usage of win32-security gem

          • High - Serious problem that could block progress.
          • Closed
          links to

          Web Link puppet stable PR #4560

          Activity

            People

              ethan Ethan Brown
              ethan Ethan Brown
              Ryan Gard Ryan Gard
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support