Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5588

Monkey patch attempts to load same certs into OpenSSL::X509::Store objects multiple times

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.4.2
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Windows 2016-04-06, Windows 2016-04-20

      Description

      We monkey patch OpenSSL::X509::Store#set_default_paths to load our own additional certs. Specifically in the case of code that uses Net::HTTP, however, the monkey patch can be invoked multiple times, and on the second and subsequent invocations the cert(s) are already loaded into the object. This causes a warning to print very verbosely, obscuring useful output.

      Puppet faces or extensions that use Net::HTTP or open-uri can trigger these superfluous warnings.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  ethan Ethan Brown
                  Reporter:
                  reid Reid Vandewiele
                  QA Contact:
                  Ryan Gard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: