Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5648

Add Iterable type and runtime object

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • PUP 4.3.1
    • PUP 4.4.0
    • None
    • None
    • 2
    • Language 2016-01-13, Language 2016-01-27, Language 2016-02-10
    • New Feature
    • Hide
      Two new types where added to the puppet type system; Iterable[T], a type for values that an iterative function can operate on (i.e. a sequence of type T), and Iterator[T] an abstract Iterable that represents a lazily applied iterative function (that produces a sequence of T). In practice an Iterable that is also an Iterator describes a value that can not be assigned directly to attributes of resources; to assign the values an Iterator must first be iterated over to construct a concrete value like an Array).

      Values of type Array, Hash, String, Integer, Iterator, and the types Type[Enum], Type[Integer] are Iterable,

      An introduction to Iterables will be available in predocs, and the specification will be updated in separate tickets linked to this ticket)
      Show
      Two new types where added to the puppet type system; Iterable[T], a type for values that an iterative function can operate on (i.e. a sequence of type T), and Iterator[T] an abstract Iterable that represents a lazily applied iterative function (that produces a sequence of T). In practice an Iterable that is also an Iterator describes a value that can not be assigned directly to attributes of resources; to assign the values an Iterator must first be iterated over to construct a concrete value like an Array). Values of type Array, Hash, String, Integer, Iterator, and the types Type[Enum], Type[Integer] are Iterable, An introduction to Iterables will be available in predocs, and the specification will be updated in separate tickets linked to this ticket)

    Description

      Commit 3a9db247c432d469e625d4abf7bee8e747178af9 regressed support for "descending" ranges, where the "max" is less than the "min":

      notice Integer[5, 1]
      		 
      Integer[5, 1].each |$x| {
      		 
        notice $x
      		 
      }

      This is expected to output:

      Notice: Scope(Class[main]): Integer[5, 1]
      		 
      Notice: Scope(Class[main]): 5
      		 
      Notice: Scope(Class[main]): 4
      		 
      Notice: Scope(Class[main]): 3
      		 
      Notice: Scope(Class[main]): 2
      		 
      Notice: Scope(Class[main]): 1

      This is because having a maximum less than a minimum treats the range as being in "descending" order.

      Instead, this is the actual output:

      Notice: Scope(Class[main]): Integer[1, 5]
      		 
      Notice: Scope(Class[main]): 1
      		 
      Notice: Scope(Class[main]): 2
      		 
      Notice: Scope(Class[main]): 3
      		 
      Notice: Scope(Class[main]): 4
      		 
      Notice: Scope(Class[main]): 5

      It appears the min and max are silently being swapped when the max < min.

      Related: I believe the compiler should error if a type is given a max argument less than a min argument when the type does not support a "descending" semantic, e.g. Callable[1, 0] should error rather than silently swapping the min and max.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. PUP-5729 Add a reverse_each function

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Task - A task that needs to be done. PUP-5771 Add introduction to Iterable and Iterator to Pre-docs for PUP-5648

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Task - A task that needs to be done. PUP-5772 Update lang specification with new types Iterable and Iterator

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PUP-5658 Disallow numeric ranges where from > to

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PUP-4702 Replace rgen model for the Puppet Type system with immutable classes

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. DOCUMENT-1293 Iterable behavior of Integers not documented?

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Accepted
          supports

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. PUP-5773 Performance Work in Puppet

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          links to

          Web Link PR-4578

          Activity

            People

              Unassigned Unassigned
              peter.huene Peter Huene
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support