Details
-
Task
-
Status: Closed
-
High
-
Resolution: Fixed
-
None
-
None
-
2
-
Windows 2016-02-24 (Burn FF), Windows 2016-03-09
-
Bug Fix
-
Description
With PUP-5538, we reduced our dependency on the win32-security gem. We should fully deprecate its usage. This includes:
- (DONE) Moving all the well-known SID constants that are being used into Puppet::Util::Windows::SID
- (DONE) Audit the modules on the forge, and notify authors up front that there might be breaking changes going forward - look for strings like win32/security, Win32::Security, etc
- (DONE) Remove the inclusion of win32/security anywhere that it occurs - for instance - https://github.com/puppetlabs/puppet/blob/ba5cfc392d597d22fa98e6d62b48f730845b6f22/lib/puppet/util/windows/security.rb#L68
- (MUCH LATER)Removal of the actual gem from the puppet-win32-ruby repository branches so that it's not included in the MSI any longer. The deprecation notice should go in Puppet 4.3.x, and the actual removal should be slated for Puppet 4.4.x
There are a number of other refactorings that should probably be done at the same time, but could be broken out to a different ticket if necessary:
(LATER)
- Move the `name_to_sid_object` method off of Puppet::Util::WIndows::SID over to Puppet::Util::Windows::SID::Principal - keep the old method around, but add a deprecation notice.
- There are likely other methods that should be refactored similarly.
- Potentially move the class Puppet::Util::Windows::SID::Principal to Puppet::Util::Windows::Principal
Attachments
Issue Links
- is blocked by
-
PUP-10953 Could not autoload puppet/provider/acl/windows: cannot load such file – win32/security
-
- Closed
-
- relates to
-
PUP-5538 Puppet fails to convert Windows Unicode group or user names to sids
-
- Closed
-
-
PUP-5923 Administration token detection doesn't work in legacy Windows OS (2003/XP)
-
- Closed
-
-
MODULES-3093 Remove usage of win32-security gem in ACL Module
-
- Accepted
-
-
FACT-1348 Remove usage of win32-security gem in Facter 2.x
-
- Closed
-
-
PUP-5560 Look at Improving Unicode for all Windows gems
-
- Resolved
-