Details
-
Task
-
Status: Closed
-
Normal
-
Resolution: Fixed
-
None
-
None
-
1
-
Windows 2016-02-10
-
Not Needed
Description
For starters, the affected parts appear to be:
- lib/puppet/feature/base.rb
- lib/puppet/util/windows/process.rb
- lib/puppet/util/pidlock.rb
- puppet/ext/windows/service/daemon.rb
- puppet/install.rb
However, note that Win32::Process actually monkey patches the process object - https://github.com/djberg96/win32-process/blob/ffi/lib/win32/process.rb
So we'll also want to look for calls to these functions as well:
get_affinitygetprioritysetpriority- https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/limits.rb#L8uid-
https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/type/exec.rb#L598 (Not applicable to Windows though. https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/type/exec.rb#L204-L209)getrlimitsetrlimit- create
https://github.com/puppetlabs/puppet/blob/master/ext/windows/service/daemon.rb#L74
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L321
TODO Add Tests kill- https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L55 / https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/execution.rb#L206get_exitcodesnapshot
Attachments
Issue Links
- relates to
-
PUP-5752 Replace win32-process calls with internal API implementations that are wide-string compatible
-
- Resolved
-
-
-
- Resolved
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Resolved
-
