Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-5814

Handle symlinks that point out of the codedir

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Normal
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When inlining metadata, we want to insure that only files in the codedir get inlined. In the case where we are following symlinks, it's possible for those symlinks to point to unversioned data. In that case we also do not want to inline them.

      Unfortunately, canonicalizing paths is hard. coreutils has a 250-line function to do it that includes multiple nested loops and a bajillion stat calls. Ideall we could cache some information about stat calls for shared path prefixes and drop that cache when the codedir changes.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                branan Branan Riley
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support