Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6125

verbose agent runs result data being sent to console and syslog

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 4.4.1
    • Fix Version/s: PUP 4.6.0
    • Component/s: None
    • Labels:
      None
    • Environment:
    • Template:
    • Story Points:
      0
    • Sprint:
      Client 2016-06-29
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      'puppet agent --verbose' used to generate log output to both console and syslog (or eventlog on Windows). When this option added to the command line '--logdest syslog', log output was still sent to both the console and
      syslog (evenlog). Now adding '--logdest syslog' causes logging to be delivered only to syslog (eventlog) and not to the console. Before (and now) using the option '--logdest console' would prevent the log output from going to the syslog (eventlog).
      Show
      'puppet agent --verbose' used to generate log output to both console and syslog (or eventlog on Windows). When this option added to the command line '--logdest syslog', log output was still sent to both the console and syslog (evenlog). Now adding '--logdest syslog' causes logging to be delivered only to syslog (eventlog) and not to the console. Before (and now) using the option '--logdest console' would prevent the log output from going to the syslog (eventlog).

      Description

      The documentation states

      • --logdest:
        Where to send log messages. Choose between 'syslog' (the POSIX syslog
        service), 'eventlog' (the Windows Event Log), 'console', or the path to a log
        file. If debugging or verbosity is enabled, this defaults to 'console'.
        Otherwise, it defaults to 'syslog' on POSIX systems and 'eventlog' on Windows.
      Flags Syslog Console
      None X  
      --logdest console   X
      --logdest syslog X  
      --verbose X X
      --verbose --logdest console   X
      --test X X
      --test --verbose X X

      This becomes a problem when the --test option is used. --test expands and sets --verbose which means diff output will get logged to syslog and the console.

      The expected result - based on logdest's documentation - is to send output only to the console, not syslog.

      This is a concern, because --test enables show-diff, which can contain secrets (such as passwords) that should not be printed. As a default, this suggests we should not log show-diff and verbose/debug output to more permanent locations such as syslog/eventlog.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                pyther Matthew Gyurgyik
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: