Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6128

QualifiedReference should retain case

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 4.5.0
    • None
    • None

    Description

      The PL parser creates a qualified reference when it encounters a name that starts with an upper-case letter. The name is immediately downcased so that all subsequent compares involving the name are case insensitive.

      In many cases it would be desired to know the original name verbatim, such as when reporting type mismatches or resources that are not found. Currently, a name like MyGreatResource will be reported as Mygreatresource (an attempt is made to make it look almost as the original) which isn't quite right.

      In order to fix this, the AST object Puppet::Pops::Model::QualifiedReference must store the name verbatim, and be able to produce both that name and the downcased name.

      ACCEPTANCE CRITERIA


      • That errors mentioning a type retains original casing

        2 =~ AbcDef
        

        Should produce an error including:

        Resource type not found: AbcDef
        

      Attachments

        Issue Links

          Activity

            People

              john.duarte John Duarte
              thomas.hallgren Thomas Hallgren
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support