Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6135

change type mismatch errors in past tense to present tense

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.8.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Puppet Developer Experience
    • Story Points:
      2
    • Sprint:
      PDS 2016-09-21, PDS 2016-10-05
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      The messages about type mismatch errors have been modified to use more consistent wording for different kinds of mismatches.

      Description

      Errors like

      attribute 'a' had wrong type, expected a Type value, got Integer/
      

      are weird, because they allude to that the thing was wrong in the past as opposed to still being wrong, which it is (unless it was corrected by magic intervention).

      There is no problem in saying
      "attribute 'a' has wrong type, expected a Type value, got Integer" since the test was performed in the past (a small amount of time ago).

      This is however painful to change as there are quite a few tests that are based on matching on the error messages.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                henrik.lindberg Henrik Lindberg
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: