Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6184

Remove win32-dir code usage from Puppet

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • PUP 7.0.0
    • Windows
    • Not Needed
    • superseded by PUP-10653

    Description

      win32-dir uses the Shell APIs to find common directories on Windows. Find an alternative solution that doesn't require CSIDL

      On a cursory look, the consumed code can be replaced with something like:

      Dir.const_set('COMMON_APPDATA', 'C:\\ProgramData')
      		 
      Dir.const_set('WINDOWS', 'C:\\Windows')
      		 
      Dir.const_set('PROFILE', 'C:\\Users\\Administrator')

      See https://gist.github.com/Iristyle/057c5560dbe64532fd1770a36e51f805 for more details on why this is important.

      A follow up to this should remove the actual gem from vendored Ruby.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MODULES-10963 reboot: Remove the usage of Win32 gems in the reboot module

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is cloned by

          Task - A task that needs to be done. FACT-1638 Remove win32-dir code / references from Facter

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          is duplicated by

          Task - A task that needs to be done. PUP-9131 Update puppet daemon.rb on windows to work without Win32 gems

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Task - A task that needs to be done. FACT-1638 Remove win32-dir code / references from Facter

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Activity

            People

              gabriel.nagy Gabriel Nagy
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support