Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6184

Remove win32-dir code usage from Puppet

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 7.0.0
    • Component/s: Windows
    • Labels:
    • Template:
    • Team:
      Night's Watch
    • Story Points:
      5
    • Sprint:
      NW - 2020-08-18
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      superseded by PUP-10653

      Description

      win32-dir uses the Shell APIs to find common directories on Windows. Find an alternative solution that doesn't require CSIDL

      On a cursory look, the consumed code can be replaced with something like:

      Dir.const_set('COMMON_APPDATA', 'C:\\ProgramData')
      Dir.const_set('WINDOWS', 'C:\\Windows')
      Dir.const_set('PROFILE', 'C:\\Users\\Administrator')
      

      See https://gist.github.com/Iristyle/057c5560dbe64532fd1770a36e51f805 for more details on why this is important.

      A follow up to this should remove the actual gem from vendored Ruby.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gabriel.nagy Gabriel Nagy
              Reporter:
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support