Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6240

Deprecate old semantic version implementation

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 4.9.0
    • None
    • None
    • Puppet Developer Experience
    • 1
    • Language 2016-06-01, PDE 2017-01-11
    • Deprecation
    • Deprecate use of Puppet::SemVer unless {{strict}} option is off
    • No Action
    • covered by unit tests; error message

    Description

      The Puppet code base currently contains two implementations to manage semantic versions.

      lib/semver.rb
      lib/puppet/vendor/semantic/...
      

      The vendored semantic package seems to be an elaboration of the one found in lib/semver.rb and is more mature. The version in lib/semver.rb should therefore be marked as deprecated (using --strict option and notify_once) and Puppet code that uses it (almost all of it under lib/puppet/module_tool) should instead use Semantic::Version and Semantic::VersionRange. Incidentally, all code that uses the semantic package also resides under lib/puppet/module_tool.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              thomas.hallgren Thomas Hallgren
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support