Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6275

Compiler PROFILE output should be logged at INFO level

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.8.0
    • Component/s: Language
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      That profiling information is generated at loglevel info to avoid having to dig out the profiling information from massive amounts of debug output.

      Show
      That profiling information is generated at loglevel info to avoid having to dig out the profiling information from massive amounts of debug output.
    • Story Points:
      2
    • Sprint:
      Language 2016-09-07
    • Release Notes:
      New Feature
    • Release Notes Summary:
      Compiler profiling is now output at log level {{info}} which removes the need to bump the log level to {{debug}}. This makes it convenient to get only the profiling information without having to restart the puppet server.

      Description

      The profile setting causes the compiler to output timing information during catalog compilation. This output can be enabled for all compilations by setting profile=true in the master's settings or on an agent-by-agent basis using the profile setting or profile flag. However, the profiling results are logged at DEBUG level by the master, which means that the master's log level has to be adjusted prior to profiling, and then reset to INFO after profiling both changes require a restart or reload of the master process.

      Given that a user already has to pass an agent flag or add a setting to trigger profile output, this data should be logged at the default level, which is INFO for Puppet Server. This change would allow agents to be profiled on demand without the need to restart or reload any Puppet Server processes.

      Current Behavior

      Profile output is logged at DEBUG level, so the log level must be temporarily increased which requires two or more Puppet Server restarts or reloads and, often manual, edits to server configuration.

      Desired Behavior

      When puppet agent -t --profile is run on an agent, PROFILE output shows up in the Puppet Server logs without any need to edit server configuration or restart/reload the server process.

        Attachments

          Activity

            People

            Assignee:
            qa qa
            Reporter:
            chuck Charlie Sharpsteen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support