Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6461

pip package provider with "ensure => latest" displays version change when there is none (problem parsing the output string in some cases)

    Details

    • Template:
    • Acceptance Criteria:
      Hide

      There should not be a version change displayed since there is no change on the server.
      This make the "idem-potency" checks acceptance tests fail.

      Show
      There should not be a version change displayed since there is no change on the server. This make the "idem-potency" checks acceptance tests fail.
    • Story Points:
      1
    • Sprint:
      Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      This removes spurious package version update notices when using the pip provider and no actual change occurred.

      Description

      When using
      package

      {'virtualenv': ensure => latest, provider => 'pip', }

      The return string from " pip install --upgrade virtualenv " is """
      Installed version (15.0.2) is most up-to-date (past versions: 15.0.2, 15.0.2, 15.0.1, 15.0.1, 15.0.0, 15.0.0, 14.0.6, 14.0.6, 14.0.5, 14.0.5, 14.0.4, 14.0.4, 14.0.3, 14.0.3, 14.0.2, 14.0.2, 14.0.1, 14.0.1, 14.0.0, 14.0.0, 13.1.2, 13.1.2, 13.1.1, 13.1.1, 13.1.0, 13.1.0, 13.0.3, 13.0.3, 13.0.2, 13.0.2, 13.0.1, 13.0.1, 13.0.0, 13.0.0, 12.1.1, 12.1.1, 12.1.0, 12.1.0, 12.0.7, 12.0.7, 12.0.6, 12.0.5, 12.0.5, 12.0.4, 12.0.4, 12.0.2, 12.0.2, 12.0.1, 12.0.1, 12.0, 12.0, 1.11.6, 1.11.6, 1.11.5, 1.11.4, 1.11.4, 1.11.3, 1.11.3, 1.11.2, 1.11.2, 1.11.1, 1.11.1, 1.11, 1.10.1, 1.10, 1.9.1, 1.9, 1.8.4, 1.8.3, 1.8.2, 1.8.1, 1.8, 1.7.2, 1.7.1.2, 1.7.1.1, 1.7.1, 1.7, 1.6.4, 1.6.3, 1.6.2, 1.6.1, 1.6, 1.5.2, 1.5.1, 1.5, 1.4.9, 1.4.8, 1.4.7, 1.4.6, 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1, 1.4, 1.3.4, 1.3.3, 1.3.2, 1.3.1, 1.3, 1.2, 1.1, 1.0, 0.9.2, 0.9.1, 0.9, 0.8.4, 0.8.3, 0.8.2, 0.8.1, 0.8)
      """

      This makes package provider print this string every single time puppet runs: """
      ensure changed '15.0.2' to '1.5'
      """

      Though nothing actually changed on the server. I tracked the issue up to:
      https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/pip.rb#L158

      Where I guess for some reason the 1.5 version is taken instead of the 15.0.2, probably due to some sorting as '.' is after '5'.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                john.duarte John Duarte
                Reporter:
                pxxsBCNhfhKh23BV Diego Abelenda
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: