[PUP-6530] create_resources() doesn't include the file or line reference in resources it creates - Puppet Jira Server

XML

Word

Printable

Acceptance Criteria:

Hide

That file and line information taken from the file/line where the call to create_resources is made is used for the file/line attributes of all resources created by the call.

Show
That file and line information taken from the file/line where the call to create_resources is made is used for the file/line attributes of all resources created by the call.
Epic Link:
4.x TechDebt
Story Points:
1
Sprint:
Language 2016-08-10, Language 2016-08-24

Release Notes:
Bug Fix
Release Notes Summary:

Hide
When creating resources using the `create_resources` function there were no file and line information included in the resulting catalog for the resources created by the function. This is now fixed and this will improve downstream tooling that requires such information.

Show
When creating resources using the `create_resources` function there were no file and line information included in the resulting catalog for the resources created by the function. This is now fixed and this will improve downstream tooling that requires such information.

Given the following Puppet code:

class system::hashadmins {

  require mysql::server

  ## Defaults

  Mysql_user {

    ensure               => present,

    max_queries_per_hour => 700,

  ## User Data

  $users = {

    'monica@localhost' => {},

    'brad@localhost'   => {},

    'luke@localhost'   => {},

    'zack@localhost'   => {

      'max_queries_per_hour' => 1300,

},

    'ralph@localhost'  => {

      'ensure' => 'absent',

  ## Call the function

  create_resources('mysql_user', $users)

...the resources that are queried look like this coming out of PuppetDB:

        "certname": "gary.puppetlabs.vm",

        "environment": "gary",

        "exported": false,

        "file": null,

        "line": null,

        "parameters": {

            "ensure": "present",

            "max_queries_per_hour": 1300

},

        "resource": "964a8bb11e504402830b17f2818b2a848b5fe4ae",

        "tags": [

            "class",

            "system::hashadmins",

            "hashadmins",

            "system",

            "mysql_user",

            "default",

            "node"

],

        "title": "zack@localhost",

        "type": "Mysql_user"

You'll note that the line and file keys are null. This causes issues down the line with coverage reports like the issue that was posted here --> https://github.com/rodjek/rspec-puppet/issues/364

is blocked by

PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling