Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6585

Remove internal usage of Puppet::Util.absolute_path?(path) / replace with Pathname.new(path)

    Details

    • Type: Improvement
    • Status: Ready for Engineering
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: PUP 4.6.0
    • Fix Version/s: PUP 5.y
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      Puppet uses `Pathname.new(path).absolute_path?` instead of `Puppet::Util.absolute_path?` "internally".

      Show
      Puppet uses `Pathname.new(path).absolute_path?` instead of `Puppet::Util.absolute_path?` "internally".
    • Epic Link:
    • Team:
      Windows
    • Story Points:
      3
    • Sprint:
      Windows Hopper

      Description

      Puppet::Util.absolute_path? was added on 8/22/2011 for Puppet 1.5.2 at https://github.com/puppetlabs/puppet/commit/fb6df317016b8bbe44116e31ac5ededa4d1e0c75 - and is nearly 5 years old.

      It was likely added due to a Ruby limitation. Ruby has a built-in check now Pathname.new(path).absolute_path? which is likely faster than our current method.

      Add a deprecation warning to the current method and call Ruby itself instead for now. Later, remove the method from Puppet::Util

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ethan Ethan Brown
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Zendesk Support