Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6629

Corrective Change YAML file causes errors when type parameter is a complex type

    XMLWordPrintable

Details

    • 2
    • Client 2016-08-24, Client 2016-09-07
    • Bug Fix
    • Hide
      Corrective change was serializing a complex type (ace in the ACL module in this case) to a yaml file that was unable to deserialized due to the type itself not handling deserialization well. Instead of handling that failure gracefully, corrective change would fail hard and cause Puppet to error. Now corrective change will fail gracefully. Changes are planned for handling the ACL module's serialization fixes in MODULES-3766.
      Show
      Corrective change was serializing a complex type (ace in the ACL module in this case) to a yaml file that was unable to deserialized due to the type itself not handling deserialization well. Instead of handling that failure gracefully, corrective change would fail hard and cause Puppet to error. Now corrective change will fail gracefully. Changes are planned for handling the ACL module's serialization fixes in MODULES-3766 .

    Description

      https://jenkins-modules.puppetlabs.com/view/3.%20windows%20only/view/acl/view/acl%20-%20master/job/forge-windows_puppetlabs-acl_intn-sys_smoke-master/PLATFORM=windows-2008r2-64a,WORKER_LABEL=beaker/20/consoleFull

       
      		 
      file { 'c:/tmp':
      		 
        ensure  => directory,
      		 
      }
      		 
       
      		 
      user { 'bob':
      		 
        ensure     => present,
      		 
        groups     => 'Users',
      		 
        managehome => true,
      		 
        password   => "L0v3Pupp3t!"
      		 
      }
      		 
       
      		 
      acl { 'c:/tmp':
      		 
        permissions  => [
      		 
          { identity => 'bob', perm_type => 'allow', rights => ['modify'] },
      		 
        ],
      		 
      }

      The permissions property of acl is a hash type. This looks to be killing runs for anyone using acl or another type that has a parameter/property that is a hash type.

      The contents of the transactionstore.yaml are as so:

      ---
      		 
      resources:
      		 
        File[c:/temp]:
      		 
          parameters:
      		 
            ensure:
      		 
              system_value: :directory
      		 
        File[c:/temp/deny_full_rights_dir]:
      		 
          parameters:
      		 
            ensure:
      		 
              system_value: :directory
      		 
        User[bob]:
      		 
          parameters:
      		 
            ensure:
      		 
              system_value: :present
      		 
            password:
      		 
              system_value: L0v3Pupp3t!
      		 
            groups:
      		 
              system_value: BUILTIN\Users,Users
      		 
        Acl[c:/temp/deny_full_rights_dir]:
      		 
          parameters:
      		 
            permissions:
      		 
              system_value:
      		 
              - !ruby/hash:Puppet::Type::Acl::Ace {}
      		 
            inherit_parent_permissions:
      		 
              system_value: :true

      Attachments

        Issue Links

          is cloned by

          Bug - A problem which impairs or prevents the functions of the product. MODULES-11312 Corrective Change YAML file causes errors when type parameter is a complex type

          • High - Serious problem that could block progress.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PUP-6630 Puppet-agent 4.6.0 throws transactionstore.yaml is corrupt with puppetlabs-acl module on Windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MODULES-5051 ACL 2.0 doesn't work with corrective change

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Ready for Engineering

          Bug - A problem which impairs or prevents the functions of the product. PCP-542 Console displays error about last_run_report.yaml could not be loaded with undefined class/module, after successfully applying a Puppet manifest

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Task - A task that needs to be done. MODULES-3766 ACL - ace should appear as a hash so it gets serialized/deserialized properly

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Ready for Engineering

          New Feature - A new feature of the product, which has yet to be developed. PUP-6295 Include corrective_change field in reports

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              qa qa
              rob Rob Reynolds
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support