Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6629

Corrective Change YAML file causes errors when type parameter is a complex type

    Details

    • Template:
    • Story Points:
      2
    • Sprint:
      Client 2016-08-24, Client 2016-09-07
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Corrective change was serializing a complex type (ace in the ACL module in this case) to a yaml file that was unable to deserialized due to the type itself not handling deserialization well. Instead of handling that failure gracefully, corrective change would fail hard and cause Puppet to error. Now corrective change will fail gracefully. Changes are planned for handling the ACL module's serialization fixes in MODULES-3766.
      Show
      Corrective change was serializing a complex type (ace in the ACL module in this case) to a yaml file that was unable to deserialized due to the type itself not handling deserialization well. Instead of handling that failure gracefully, corrective change would fail hard and cause Puppet to error. Now corrective change will fail gracefully. Changes are planned for handling the ACL module's serialization fixes in MODULES-3766 .

      Description

      https://jenkins-modules.puppetlabs.com/view/3.%20windows%20only/view/acl/view/acl%20-%20master/job/forge-windows_puppetlabs-acl_intn-sys_smoke-master/PLATFORM=windows-2008r2-64a,WORKER_LABEL=beaker/20/consoleFull

       
      file { 'c:/tmp':
        ensure  => directory,
      }
       
      user { 'bob':
        ensure     => present,
        groups     => 'Users',
        managehome => true,
        password   => "L0v3Pupp3t!"
      }
       
      acl { 'c:/tmp':
        permissions  => [
          { identity => 'bob', perm_type => 'allow', rights => ['modify'] },
        ],
      }
      

      The permissions property of acl is a hash type. This looks to be killing runs for anyone using acl or another type that has a parameter/property that is a hash type.

      The contents of the transactionstore.yaml are as so:

      ---
      resources:
        File[c:/temp]:
          parameters:
            ensure:
              system_value: :directory
        File[c:/temp/deny_full_rights_dir]:
          parameters:
            ensure:
              system_value: :directory
        User[bob]:
          parameters:
            ensure:
              system_value: :present
            password:
              system_value: L0v3Pupp3t!
            groups:
              system_value: BUILTIN\Users,Users
        Acl[c:/temp/deny_full_rights_dir]:
          parameters:
            permissions:
              system_value:
              - !ruby/hash:Puppet::Type::Acl::Ace {}
            inherit_parent_permissions:
              system_value: :true
      

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  qa qa
                  Reporter:
                  rob Rob Reynolds
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  10 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: