[PUP-6682] $settings leaks symbols into manifests - Puppet Tickets

Details

Release Notes:
Bug Fix
Release Notes Summary:

Hide
A problem was fixed regarding settings values set in variables in the 'settings' namespace where settings that internally used Ruby Symbols leaked those into the Puppet Language making it impossible to compare them with String values. Now, those settings (as well as all others not having a Puppet Language representation) are turned into values that can be used.

Show
A problem was fixed regarding settings values set in variables in the 'settings' namespace where settings that internally used Ruby Symbols leaked those into the Puppet Language making it impossible to compare them with String values. Now, those settings (as well as all others not having a Puppet Language representation) are turned into values that can be used.

% puppet apply -e '$be = $settings::storeconfigs_backend notice(inline_template("<%= @be.class %>"))'

Notice: Scope(Class[main]): Symbol

and therefore

% puppet apply -e 'notice($settings::storeconfigs_backend == "puppetdb")'

Notice: Scope(Class[main]): false

This stuff should be stringified I guess, and in general $settings is just horrible and should be a hash.

relates to

PUP-1581 Agent settings should be available within the parser

PUP-6692 Improve access to "master" settings