Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6693

Warn/error if $trusted_server_data is assigned if not in --trusted_server_facts mode and --strict is on

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.8.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      That --strict controls if assignment to $server_facts is a warning, error or ignored when --trusted_server_facts is false.

      Show
      That --strict controls if assignment to $server_facts is a warning, error or ignored when --trusted_server_facts is false.
    • Epic Link:
    • Team:
      Puppet Developer Experience
    • Story Points:
      1
    • Sprint:
      PDS 2016-09-21, PDS 2016-10-05
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      If an assignment was made to {{$server_facts}} and {{\--trusted_server_facts}} was not in effect there was no warning. Now this is controlled by the {{\--strict}} option. This makes it easier to prepare for a later update when {{\--trusted_server_facts}} is on by default.
      Show
      If an assignment was made to {{$server_facts}} and {{\--trusted_server_facts}} was not in effect there was no warning. Now this is controlled by the {{\--strict}} option. This makes it easier to prepare for a later update when {{\--trusted_server_facts}} is on by default.

      Description

      We are planning to throw the switch on --trusted_server_data in Puppet 5.0.0 (PUP-6612). The current implementation does however not issue a deprecation warning for an assignment to $server_facts and it would then simply error on 5.0.0.

      To make that better, we can use --strict to control if assignment to $server_facts should be a warning, error, or be ignored. That gives users a chance to fix this before they upgrade.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                henrik.lindberg Henrik Lindberg
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: