Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6875

[Spike] Investigate usage of ReGex \w character class in Puppet

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Ready for Engineering
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: PUP 5.y
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      Tickets are created for specific \w replacement efforts

      Show
      Tickets are created for specific \w replacement efforts
    • Team:
      Coremunity
    • Story Points:
      3

      Description

      The \w character class in Ruby does not support Unicode and will only match on [a-zA-z0-9_] which is limiting.

      Instead, we should generally be using [[:word:]] where Unicode is important within a regex. This ticket involves auditing the existing code to identify critically important areas where this may be a problem in types / providers, gems, etc. Note that the Unicode compliant word character class will be slower than the ASCII version, so it would be good to keep an eye on performance as changes are proposed / made

      This could also extend to supported modules, but should probably be a new ticket.

      In scope for Agent + Platform Team
      • Identify areas of concern, file tickets, assess impact and priority.
      • Analysis of gems should limit scope (using --without development flag to bundler).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Zendesk Support