[PUP-6876] Puppet::Settings::IniFile doesn't handle Unicode keys / sections properly - can cause `config set` / `config print` failures - Puppet Jira Server

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Normal
Resolution: Fixed
Affects Version/s: PUP 4.8.0
Fix Version/s: PUP 4.8.1
Component/s: None
Labels:
None

Acceptance Criteria:

Hide

Tests prove that INI files can parse properly with UTF-8

Show
Tests prove that INI files can parse properly with UTF-8
Epic Link:
Phase 1 Puppet Unicode Adoption Blockers
Team:
Agent
Story Points:
2
Sprint:
AP 2016-11-16

Description

While working on ~~PUP-6188~~, it was discovered that puppet config set and puppet config print did not behave properly when using UTF-8 characters in the puppet.conf INI file.

This was traced back to a problem in Puppet::Settings::IniFile and it's ability to properly parse key / value pairs. In particular, RegEx \w character class doesn't work for Unicode, but [[:word:]] does - see more details in PUP-6875

Note that there might be 2 separate INI file parsers inside Puppet itself, and another in the INI module that might be worth investigating here.

Attachments

Issue Links

blocks

PUP-6188 Document Puppet::FileSystem.open / exclusive_open encoding usage, and make existing code explicitly use encodings

Closed

relates to

PUP-6875 [Spike] Investigate usage of ReGex \w character class in Puppet

Ready for Engineering

PUP-6188 Document Puppet::FileSystem.open / exclusive_open encoding usage, and make existing code explicitly use encodings

Closed

Activity

People

Assignee:: Glenn Sarti

Reporter:: Ethan Brown

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2016/11/03 2:43 PM

Updated:: 2016/11/22 2:58 PM

Resolved:: 2016/11/15 7:54 AM