Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6925

Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • PUP 4.8.0
    • PUP 4.9.0
    • None
      • All tests pass in places where encoding needed to change.
      • New tests demonstrate behavior is correct.
      • New acceptance tests may be needed.
    • Agent
    • 3
    • AP 2016-11-30, AP 2016-12-14, AP 2017-01-11, AP 2017-01-25, AP 2017-02-08
    • Not Needed
    • No Action
    • [Bulk update] Testing, infrastructure, research tickets do not require risk assessment

    Description

      There are still a smattering of calls to File.open or similar in the Puppet code that should use Puppet::FileSystem and that should explicitly specify an encoding.

      Make sure UTF-8 is used where possible, but be careful to leave some calls as the default Encoding.default_external in the case they are operating system managed files or expect different encodings.

      This is an extension of work started in PUP-6188 which was about how to use FileSystem.open or FileSystem.exclusive_open with an encoding.

      Attachments

        Issue Links

          is cloned by

          Improvement - An improvement or enhancement to an existing feature or task. PUP-7134 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding for SSL files

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. PUP-6188 Document Puppet::FileSystem.open / exclusive_open encoding usage, and make existing code explicitly use encodings

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PUP-6986 Service provider fails when hasstatus => false and the output of 'ps -ef' happens to contains non-ASCII chars

          • Major - Major loss of function.
          • Closed

          Activity

            People

              ethan Ethan Brown
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support