Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-6989

Acceptance testing using TYPE=git and preserved hosts is broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.9.0
    • Component/s: None
    • Labels:
    • Template:
    • Acceptance Criteria:
      Hide

      It must be possible for a developer to run acceptance tests before submitting PR that changes the puppet code-base.

      Show
      It must be possible for a developer to run acceptance tests before submitting PR that changes the puppet code-base.
    • Story Points:
      3
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      No Action

      Description

      I tried to use the acceptance tests with TYPE=git today and ran into several problems.

      • All tests using the latest master fails on missing semantic_puppet. This is because it is missing from the config/git/options.rb and also from the install.rb.
      • Adding semantic_puppet to install.rb doesn't work because it lacks an install.rb of its own.
      • The Rake command ci:list_preserved is broken. It looks for files directly under the log directory. The files however, resides one level down, under log/<config>.
      • Once I got ci:list_preserved working, I found that the ci:test_against_preserved_hosts is also broken. It does not propagate preserved hosts correctly (a variable named config is assumed to be present at line 123, but it isn't and instead a method is called that picks a host seemingly at random). I used the temporary fix of setting config = final_options[:hosts_file] to get around this but then it breaks with other commands.

      Without this functionality working, it's very hard to assert that changes made to the code will not break once the reach the CI-pipeline.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                josh Josh Cooper
                Reporter:
                thomas.hallgren Thomas Hallgren
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support