Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7066

Revert #5237 and modify to return string content with deprecation

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: PUP 4.8.0, PUP 4.8.1
    • Fix Version/s: PUP 4.7.1, PUP 4.8.2, PUP 4.9.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Agent
    • Story Points:
      2
    • Sprint:
      AP 2017-01-11
    • Release Notes:
      Deprecation
    • Release Notes Summary:
      Hide
      In Puppet 4.8.0, the stacktrace property was removed from Puppet's HTTP error response API. This was an unintentional backwards-incompatible change, and in Puppet 4.8.2, the stacktrace property was returned to the response object, but instead of containing the stack trace message, now contains a deprecation warning. Users consuming the stack trace property of the Puppet HTTP error response API should instead review the Puppet log for this information.
      Show
      In Puppet 4.8.0, the stacktrace property was removed from Puppet's HTTP error response API. This was an unintentional backwards-incompatible change, and in Puppet 4.8.2, the stacktrace property was returned to the response object, but instead of containing the stack trace message, now contains a deprecation warning. Users consuming the stack trace property of the Puppet HTTP error response API should instead review the Puppet log for this information.
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      Extremely low risk of downtime or data loss

      Description

      https://github.com/puppetlabs/puppet/pull/5237 introduced a potentially backwards-incompatible change, modifying the http error response object schema to remove the stacktrace element.

      For the 4.x series, we should instead return a string, issuing a deprecation, in line with the schema but no longer including the data to be hidden.

      In puppet 5.x, the element can be removed.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  moses Moses Mendoza
                  Reporter:
                  moses Moses Mendoza
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support