Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7104

Serialization of Sensitive with rich data is incorrect

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.9.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      That Sensitive rich data can be serialized and that the implementation is designed to work for both JSON and MessagePack.

      Show
      That Sensitive rich data can be serialized and that the implementation is designed to work for both JSON and MessagePack.
    • Team:
      Puppet Developer Experience
    • Story Points:
      1
    • Sprint:
      PDE 2017-01-25
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      Not used or seen by anyone so no need to have a release note.
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      internal changes, covered by existing tests

      Description

      The current implementation of Sensitive serialization is broken. It assumes that the same packer can be used for both normal data and extension data. As a consequence, it attempts to write rich data directly into the extension buffer. While fine for JSON, this approach doesn't work at all for MessagePack.

      The fix for this was originally included in a PR for PUP-5908. That ticket is however stalled and since the fix changes the actual format, it's important that it gets included in the next release.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              thomas.hallgren Thomas Hallgren
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support