Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7134

Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding for SSL files

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 4.8.0
    • Fix Version/s: PUP 4.10.0
    • Component/s: None
    • Labels:
    • Template:
    • Acceptance Criteria:
      • All tests pass in places where encoding needed to change.
      • New tests demonstrate behavior is correct.
      • New acceptance tests may be needed.
    • Team:
      Agent
    • Story Points:
      2
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      [Bulk update] Testing, infrastructure, research tickets do not require risk assessment

      Description

      This is an extension of work from PUP-6925. That ticket originally also covered SSL files, but due to time constraints those efforts have been moved to this ticket.

      The original PUP-6925 ticket description follows:

      There are still a smattering of calls to File.open or similar in the Puppet code that should use Puppet::FileSystem and that should explicitly specify an encoding.

      Make sure UTF-8 is used where possible, but be careful to leave some calls as the default Encoding.default_external in the case they are operating system managed files or expect different encodings.

      This is an extension of work started in PUP-6188 which was about how to use FileSystem.open or FileSystem.exclusive_open with an encoding.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  ethan Ethan Brown
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: