Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7184

Puppet::FileSystem should implement `readlines`

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: PUP 4.9.1
    • Fix Version/s: PUP 5.y
    • Component/s: None
    • Labels:
    • Template:
    • Acceptance Criteria:
      • All callers of File.readlines and replaced with Puppet::FileSystem.readlines
      • Callers explicitly pass an encoding instead of relying on Ruby defaults
    • Team:
      Coremunity
    • QA Risk Assessment:
      Needs Assessment

      Description

      In an effort to purge all usage of Ruby File (for consistency), to instead use Puppet::FileSystem (which has better Windows support), it was discovered that calls to File.readlines cannot be removed because there is no equivalent within Puppet::FileSystem.

      This ticket involves adding an implementation, and updating callers where appropriate.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            ethan Ethan Brown
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Zendesk Support