Details
-
Task
-
Status: Closed
-
Normal
-
Resolution: Fixed
-
None
-
None
-
None
-
- Puppet 5 masters accept JSON facts
- Puppet 5 masters accept PSON facts
- JSON facts are not double-CGI encoded.
-
Agent
-
3
-
Agent 2017-05-03, Agent 2017-05-31
-
New Feature
-
The puppet master can now accept JSON encoded facts, but will continue to accept PSON encoded facts from older agents.
-
No Action
Description
At https://github.com/puppetlabs/puppet/blob/master/lib/puppet/configurer/fact_handler.rb#L35 we "extra" CGI.escape the facts content we are going to include in the body that gets sent to the master.
We do not need to do this. We should just url encode the whole body that gets sent.
Update (or equivalent):
{:facts_format => :pson, :facts => CGI.escape(text)}
|
to something like:
{:facts_format => :json, :facts => facts.to_json}
|
Attachments
Issue Links
- blocks
-
PUP-7487 Default to JSON when sending facts and reports
-
- Closed
-