Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7313

Shorten the time it takes to initialize the compiler and its scope

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.10.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      That hiera_include_one shows at least 30% increase in performance.

      Show
      That hiera_include_one shows at least 30% increase in performance.
    • Team:
      Puppet Developer Experience
    • Story Points:
      2
    • Sprint:
      PDE 2017-03-08, PDE 2017-03-22
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      A small performance optimization was made in the time it takes to initialize the compiler. While there is a noticeable speedup in initializing the compiler itself - the user observable actions of 'puppet apply' etc. have so much other things going on that this is dwarfed and is therefore almost unnoticeable (in the 1-2% range), it does make a difference in benchmarks (finding the real code to optimize), and will have a positive effect on running tests involving the compiler.
      Show
      A small performance optimization was made in the time it takes to initialize the compiler. While there is a noticeable speedup in initializing the compiler itself - the user observable actions of 'puppet apply' etc. have so much other things going on that this is dwarfed and is therefore almost unnoticeable (in the 1-2% range), it does make a difference in benchmarks (finding the real code to optimize), and will have a positive effect on running tests involving the compiler.
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      perf; covered by unit benchmarks and tests

      Description

      The benchmark hiera_include_one recreates the compiler in each iteration. Profiling of that benchmark has revealed a couple of places where the code can be improved to consume a lot less CPU cycles.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            thomas.hallgren Thomas Hallgren
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support