Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7602

If the catalog contains binary content, the server should downgrade to pson

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 5.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Agent
    • Story Points:
      3
    • Sprint:
      Agent 2017-06-14, Agent 2017-06-28
    • Method Found:
      Needs Assessment
    • Release Notes:
      New Feature
    • Release Notes Summary:
      If the server compiles a catalog, and it contains binary data, typically as a result of inlining a file into the catalog using `content => file("/path/to/file")`, then the server will transfer the catalog as PSON instead of JSON.
    • QA Risk Assessment:
      Automate

      Description

      If the catalog contains binary content, then the master won't be able to serialize it to json, generating an HTTP 500 error. To make it easy to migrate to Puppet 5, the master should detect when there is an encoding error when serializing the catalog, and downgrade to pson. It should also emit the correct mime-type.

      The agent should still be able to cache the catalog (as PSON), and later load the catalog and apply, e.g. puppet agent -t --use_cached_catalog.

      This issue is blocking puppetdb tests because they verify binary file content transfer from agent to server to puppetdb.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              josh Josh Cooper
              QA Contact:
              John Duarte John Duarte
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support