Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7603

StringConverter should be more diligent about using single quotes

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 5.0.0
    • None
    • None
    • Agent
    • 1
    • Agent 2017-06-14
    • Needs Assessment
    • Not Needed
    • Problem fixed before release
    • No Action
    • Check in includes tests for the change

    Description

      The `StringConverter`, when converting strings to their '%p' format, will currently use double quotes in many cases where it is unnecessary. In essence, the only time that double qoutes are needed when producing a string, is when the string contains control characters (codepoint < 0x20) or non-ascii characters (codepoint > 0x7f). In all other cases, it's desirable to use single quotes since the representation gets more compact and is more efficient to parse.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              thomas.hallgren Thomas Hallgren
              Eric Delaney Eric Delaney
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support