Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7603

StringConverter should be more diligent about using single quotes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 5.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Sub-team:
    • Team:
      Agent
    • Story Points:
      1
    • Sprint:
      Agent 2017-06-14
    • Method Found:
      Needs Assessment
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      Problem fixed before release
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      Check in includes tests for the change

      Description

      The `StringConverter`, when converting strings to their '%p' format, will currently use double quotes in many cases where it is unnecessary. In essence, the only time that double qoutes are needed when producing a string, is when the string contains control characters (codepoint < 0x20) or non-ascii characters (codepoint > 0x7f). In all other cases, it's desirable to use single quotes since the representation gets more compact and is more efficient to parse.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              thomas.hallgren Thomas Hallgren
              QA Contact:
              Eric Delaney Eric Delaney
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support