Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7630

"Successful" puppet agent reports hide provider errors

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: PUP 4.7.0, PUP 4.9.4
    • Fix Version/s: PUP 5.4.0
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Acceptance Criteria:
      Hide

      When a provider fails in prefetch:
      1. The agent run should be reported as failed.
      2. Resources that use that provider should be marked as failed and not evaluated.
      3. Resources that depend on resources that use that provider should not be evaluated.
      4. Unrelated resources should still run.

      Show
      When a provider fails in prefetch: 1. The agent run should be reported as failed. 2. Resources that use that provider should be marked as failed and not evaluated. 3. Resources that depend on resources that use that provider should not be evaluated. 4. Unrelated resources should still run.
    • Sub-team:
    • Team:
      Platform Core
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Customer Feedback
    • CS Priority:
      Major
    • CS Frequency:
      4 - 50-90% of Customers
    • CS Severity:
      3 - Serious
    • CS Business Value:
      4 - $$$$$
    • CS Impact:
      Hide
      This has been a long standing issue. The console should not show a node as "unchanged" when there is an error in the report.

      Some customers never look into node reports unless it shows as an error on the front page of the console and due to this they probably won't notice these errors. False negatives are not good.
      Show
      This has been a long standing issue. The console should not show a node as "unchanged" when there is an error in the report. Some customers never look into node reports unless it shows as an error on the front page of the console and due to this they probably won't notice these errors. False negatives are not good.
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Providers that fail in prefetch will now cause the resources that use them to fail and not be evaluated. This will not affect other resources or providers that are not dependent on the failed provider and resources.
    • QA Risk Assessment:
      No Action

      Description

      It's possible to get a successful agent run report that on closer inspection include errors.

      For instance, an error points to a failure with the Chocolatey provider. Because the provider failed out, it did not return a complete list of resources to manage, and the agent run completes successfully on this smaller catalog without raising an alarm.

      There is no way for an administrator to notice this problem and correct it without drilling down into green agent reports to confirm whether an error has occurred or not. On large scale deployments this solution rapidly becomes unmanageable.

      Agent runs need to return some condition when providers fail that highlights that this has occurred. There needs to be a scaleable way to monitor and report on this kind of failure.

      Please add all errors and warnings for consideration as failed run status assignment criteria here.

        Attachments

        1. break_stuff.tar.gz
          0.6 kB
        2. compile_failed.png
          compile_failed.png
          848 kB
        3. deprecation_warning.png
          deprecation_warning.png
          831 kB
        4. fact_failed.png
          fact_failed.png
          836 kB
        5. pluginsync_failed.png
          pluginsync_failed.png
          858 kB
        6. Screen Shot 2017-04-25 at 2.15.45 PM.png
          Screen Shot 2017-04-25 at 2.15.45 PM.png
          107 kB

          Issue Links

            Activity

              People

              • Assignee:
                eric.delaney Eric Delaney
                Reporter:
                paul.schaffer Paul Schaffer
              • Votes:
                3 Vote for this issue
                Watchers:
                20 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support