Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-7952

Types with a trailing comma fail on 5.2.0

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 5.2.0
    • Fix Version/s: PUP 5.3.1
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Platform Core
    • Story Points:
      1
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Customer Feedback
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      A regression has been fixed where an optional trailing comma stopped working when specifying a type alias. For example, {{type X = Variant\[Integer,]}} led to a syntax error. This feature has now been brought back.
    • QA Risk Assessment:
      No Action
    • QA Risk Assessment Reason:
      tests added with code change

      Description

      Type Aliases are broken if they include a trailing comma during testing on 5.2.0.

      I created a demo repository with a Travis hook right here: https://github.com/pegasd/puppet-broken_type

      As you can see from the latest build, both types work fine under 5.1.0, but one of them (with a trailing comma) fails:
      https://travis-ci.org/pegasd/puppet-broken_type

        Attachments

          Activity

          Hide
          pegas PegaS added a comment -

          Just a guess, but it might have to do with PUP-7885 or PUP-7835.

          Show
          pegas PegaS added a comment - Just a guess, but it might have to do with PUP-7885 or PUP-7835 .
          Hide
          kenn Kenn Hussey added a comment -
          Show
          kenn Kenn Hussey added a comment - Thomas Hallgren Henrik Lindberg FYI.
          Hide
          thomas.hallgren Thomas Hallgren added a comment -

          The regression was introduced in PUP-7853.

          Show
          thomas.hallgren Thomas Hallgren added a comment - The regression was introduced in PUP-7853 .

            People

            • Assignee:
              Unassigned
              Reporter:
              pegas PegaS
              QA Contact:
              Eric Delaney
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support