Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8009

Performance regression with lots of modules and gettext

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: PUP 5.3.1
    • Fix Version/s: PUP 5.3.2
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Direct Change
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Introduction of i18n for modules can cause significant performance regressions if environment caching is not used (i.e. environment_timeout==0), even if no translations from those modules are used. Introduce a disable_i18n flag to allow turning off translation functionality if not needed.
      Show
      Introduction of i18n for modules can cause significant performance regressions if environment caching is not used (i.e. environment_timeout==0), even if no translations from those modules are used. Introduce a disable_i18n flag to allow turning off translation functionality if not needed.
    • QA Risk Assessment:
      Needs Assessment

      Description

      We've seen a ~30% reduction in compilation capacity with Puppet 5.3 (over Puppet 4.10). It appears to be related to gettext setup at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/gettext/config.rb#L37-L69.

      We haven't fully isolated why, but the best guess is that code related to accessing modules during compilation is being called too frequently, and resulting in lots of disk-related activity.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  michael.smith Michael Smith
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  13 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support