-
Type:
Bug
-
Status: Closed
-
Priority:
Normal
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: None
-
Labels:None
-
Template:
-
Epic Link:
-
Sub-team:
-
Team:Platform Core
-
Sprint:Platform Core KANBAN
-
Method Found:Inspection
-
Release Notes:Not Needed
-
QA Risk Assessment:No Action
We need to review the PO file and source code of puppet looking for strings where we build up a list of things where we include sentence fragment in the repeated list and determine if this should be change to allow for better translations
For example the below code includes a sentence fragment "which depends on" which will be hard to translate into Japanese, We should create a list of cases, review them and determine which ones we want to change string in.
lib/puppet/module_tool/errors/shared.rb
_(" which depends on '%{name}' (%{version})") % { name: m[:name], version: v(m[:version]) }
|
dependency_list = @source[1..-1].map do |m|
|
#TRANSLATORS This message repeats as separate lines as a list under the heading "You specified '%{name}' (%{version})\n"
|
_(" which depends on '%{name}' (%{version})") % { name: m[:name], version: v(m[:version]) }
|
end.join(",\n")
|
|
msg_variables = { requested_module: @requested_module, version: v(@requested_version), module_name: @module_name,
|
name: @source.first[:name], dependency_list: dependency_list }
|
_(<<-EOM).chomp % msg_variables
|
Could not install module '%{requested_module}' (%{version})
|
No version of '%{module_name}' will satisfy dependencies
|
You specified '%{name}' (%{version})
|
%{dependency_list}
|
Use `puppet module install --force` to install this module anyway
|
EOM
|
We should look to update the repeated list text to be (and remove the TRANSLATOR comment)
_(" This depends on '%{name}' (%{version})") % { name: m[:name], version: v(m[:version]) }
|
- relates to
-
PUP-8092 Concatenated strings causing breakages with Japanese group 2
-
- Closed
-