Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8199

Parameters in Task metadata should not collide with metadata keys

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • PUP 5.4.0
    • PUP 4.10.0, PUP 5.4.0
    • None
    • Hide

      Tasks should be allowed to declare parameters such as description.

      Show
      Tasks should be allowed to declare parameters such as description .
    • Bolt
    • Bolt Kanban
    • Needs Assessment
    • Bug Fix
    • Hide
      This is for Bolt

      This fixes a bug where bolt parameter names that conflicted with top level metadata keys(parameters, input_method etc) were ignored.

      Breaking Change: Previously tasks were types in Puppet and the run task function could be called with a reference the Type itself or an instance of the type. With this change that is no longer the case and tasks must be referred to by their lower case task name
      The following invocations are no longer valid
      run_task(My_app::Deploy(), ....
      run_task(My_app::Deploy, ....
      And should be converted to
      run_task(my_app::deploy, ...
      or
      run_task('my_app::deploy', ...
      Show
      This is for Bolt This fixes a bug where bolt parameter names that conflicted with top level metadata keys(parameters, input_method etc) were ignored. Breaking Change: Previously tasks were types in Puppet and the run task function could be called with a reference the Type itself or an instance of the type. With this change that is no longer the case and tasks must be referred to by their lower case task name The following invocations are no longer valid run_task(My_app::Deploy(), .... run_task(My_app::Deploy, .... And should be converted to run_task(my_app::deploy, ... or run_task('my_app::deploy', ...
    • Needs Assessment

    Description

      If a task declares a parameter that is also a metadata key, such as description, Puppet will fail to load the task.

      With BOLT-66:

      $ bolt task run echo message='{"a": 1}' -n node --modulepath site
      Error: attribute Echo[description] is defined as both a constant and an attribute on node mylaptop
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              michael.smith Michael Smith
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support