Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8246

Consolidate http client connection implementations

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Epic Link:
    • Team:
      Coremunity
    • QA Risk Assessment:
      Needs Assessment

      Description

      This ticket is a result of PUP-7482.

      Puppet does not allow callers to specify which CA certs should be trusted when making SSL connections (see PUP-5069). As a result, there are three places where we create SSL connections, and configure the X509::Store:

      1. puppet/network/http/factory
      2. puppet/util/http_proxy
      3. puppet/forge/repository
      

      There are several inconsistencies as a result:

      1. persistent connections are used for 1, but not 2
      2. We send "Ruby" as the user-agent for 2
      3. We don't send the X-PUPPET-VERSION header for 2
      4. 1 and 2 handle proxy settings differently.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              josh Josh Cooper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support