Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8257

Puppet::FileSystem::Windows should support LFN

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Duplicate
    • None
    • None
    • None
    • Night's Watch
    • Needs Assessment
    • 45348
    • 1
    • Needs Assessment

    Description

      As mentioned in PUP-4866 & PUP-6152, there is support for using long file names greater than 260 characters in Windows by using the "\\?\" prefix.

      Unfortunately, this doesn't quite work with Ruby's normal file path handling, as it also uses "/" on Windows as the path separator, and this needs to be converted to "\" for the "\\?\" prefix to work. Because of the requirement to translate "/" to "\" on the final file path for the "\\?\" LFN prefix to work, we should probably be putting the LFN support directly in to Puppet::FileSystem::Windows, and making sure that we are not using the native Ruby file path handling methods (Eg: File.expand_path, File.join, etc.) anywhere, and are using the Puppet::FileSystem versions instead.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. PUP-10924 `module install` can't unpack modules with long paths because of minitar bug

          • High - Serious problem that could block progress.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PA-3759 Patch our vendored Ruby to allow long paths on Windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. PUP-6152 PMT Should Use Long File Name (LFN) Paths on Windows

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PUP-4866 Plugin Sync Should Use Long File Name (LFN) Paths on Windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              Unassigned Unassigned
              jacob.helwig Jacob Helwig
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support