Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8463

Remove existing warnings and run PRs through 'ruby -wc'

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 5.5.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Sub-team:
    • Team:
      Platform Core
    • Sprint:
      Platform Core KANBAN
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      No Action

      Description

      Puppet currently has a large number of Ruby warnings that should be cleaned up as some of them are causing actual bugs.

      How to find all of the Ruby warnings in the Puppet repo (this will be slow):

      find lib spec -type f -name \*.rb | xargs -n1 ruby -wc > /dev/null
      

      After all of the warnings have been removed, we should update Travis CI to run any Ruby file changed in a PR through "ruby -wc" to make sure that we don't reintroduce any warnings (or potential bugs that would have been caught by the warnings).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              eric.delaney Eric Delaney
              Reporter:
              jacob.helwig Jacob Helwig
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support